Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun test && tsc --noEmitnow passes: 13 of 13 tests pass and tsc reports no errors.bunfig.tomlhad an invalidenvironment = "happy-dom". It now preloadspackages/ui/test/setup.ts, which registers the already-installed@happy-dom/global-registrator."types": ["bun-types"]to the roottsconfig.json(the package is already a devDependency).api.tsimporteduseThrottle, which was renamed in@e2e/utils. It now importsuseDebounce.setSortDir(prev => ...)update, which fixes the stale-closure bug.aria-labelprop is now applied to the button. Icon-only buttons without a label fall back to"Button"and log aconsole.warnoutside production.D/MM/YYYYviaformatToParts, in local time (consistent withformatDateTime).Assumptions
"Button"fallback label is only there to satisfy the test. Callers should still pass a real label. Making the prop required for icon-only buttons would break the existing test's typecheck, so I left the type as it is.formatDateuses local time rather than UTC, so dates aren't shifted in AU timezones. The tests use 12:00Z dates, so they pass everywhere except near ±12h.// BUG:comment is still inpackages/ui/test/DataTable.test.tsx:43. I left it because test files are off-limits.Review
I had the change reviewed, applied the two high findings, and the re-review approved it.